crysknife-io / crysknife

Dependency Injection and html templates framework for J2CL. Relaxed implementation of Jakarta CDI
Apache License 2.0
27 stars 8 forks source link

now google guava is shaded #35

Closed treblereel closed 4 years ago

treblereel commented 4 years ago

it isn't necessary to add crysknife annotation to the deps little error logging fix

hrstoyanov commented 4 years ago

@treblereel are you removing guava? At the time, I removed a lot of dependencies from Errai, but could not get rid of Guava, because some Guava classes already leaked into the public Errai API (like pages). If you have the opportunity and want to tweak the Errai public APIs, please remove guava - there are ways to acheve the same with modern Java.

treblereel commented 4 years ago

@hrstoyanov nope, i have some issues using guava, so i did a working port of it. here https://github.com/treblereel/crysknife/tree/master/ui/databinding/api/src/main/java/com/google/common

treblereel commented 4 years ago

@hrstoyanov Yeap, you are right, i ll do that, i need guava mostly because some ported code still uses some guava collections like Multimap and so on, i think it's better to rewrite it coz it adds ~140kb to the project which use it, without any profit.

hrstoyanov commented 4 years ago

Exactly! And this Multimaps in the public pages API can be re-done with something standard, because crysknife is separate project and breaking changes are ok.