cryspen / hacl-packages

The Cryspen HACL Distribution
https://cryspen.com/hacl-packages
Other
13 stars 18 forks source link

ed25519 benchmarks #280

Closed franziskuskiefer closed 1 year ago

franziskuskiefer commented 1 year ago

Simple sign and verify benchmarks for ed25519 for https://github.com/hacl-star/hacl-star/pull/710.

franziskuskiefer commented 1 year ago

Do we measure hex-decoding + {sign, verfiy}? That should be fine to detect performance regressions? If we want to obtain numbers on sign and verify, maybe it would be better to already use a static uint8_t*? This would also reduce duplication of the message and key literals?

Not sure how Google Benchmark works. Does state.KeepRunning() signal the start of the measurement?

Nope, only the loop is measured.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3548464424


Totals Coverage Status
Change from base Build 3516015739: 0.0%
Covered Lines: 33230
Relevant Lines: 61554

💛 - Coveralls