Closed franziskuskiefer closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/EverCrypt_Hash.c | 61 | 62 | 98.39% | ||
src/EverCrypt_Poly1305.c | 0 | 2 | 0.0% | ||
src/Hacl_Streaming_Blake2s_128.c | 0 | 4 | 0.0% | ||
src/Hacl_Streaming_MD5.c | 0 | 4 | 0.0% | ||
src/Hacl_Streaming_SHA3.c | 4 | 8 | 50.0% | ||
src/Hacl_Streaming_Poly1305_256.c | 0 | 6 | 0.0% | ||
src/Hacl_Hash_Blake2.c | 0 | 8 | 0.0% | ||
src/EverCrypt_HMAC.c | 140 | 151 | 92.72% | ||
src/Hacl_HMAC.c | 140 | 151 | 92.72% | ||
src/Hacl_Streaming_SHA2.c | 25 | 44 | 56.82% | ||
<!-- | Total: | 454 | 716 | 63.41% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/EverCrypt_Poly1305.c | 1 | 20.93% | ||
src/Hacl_EC_K256.c | 1 | 21.15% | ||
src/Hacl_HMAC_Blake2b_256.c | 1 | 0% | ||
src/Hacl_HMAC_Blake2s_128.c | 1 | 0% | ||
src/Hacl_Streaming_Blake2s_128.c | 1 | 0% | ||
src/Hacl_Streaming_MD5.c | 1 | 0% | ||
src/Hacl_Streaming_Poly1305_256.c | 1 | 0% | ||
src/EverCrypt_HMAC.c | 4 | 87.12% | ||
src/Hacl_HMAC.c | 4 | 90.68% | ||
<!-- | Total: | 15 | --> |
Totals | |
---|---|
Change from base Build 3766718490: | -2.4% |
Covered Lines: | 30653 |
Relevant Lines: | 57201 |
@victor-dumitrescu can you have a look at the ocaml error here? It complains that bytes_size
is undefined. It works locally for me though.
The issue seems to be that I didn't put a version constraint on qcheck-core
, which introduced bytes_size
in version 0.20. Not sure why, but CI doesn't install the most recent version, but goes for 0.19.1 instead https://github.com/cryspen/hacl-packages/actions/runs/3795098970/jobs/6453866955#step:8:26
I'll open a PR on hacl-star to specify >= 0.20.0
Updating to HACL* db8fc63f10e8b16438f3dae6d4872d84702f83d1