cryspen / hacl-packages

The Cryspen HACL Distribution
https://cryspen.com/hacl-packages
Other
13 stars 18 forks source link

benchmarks: Implement/Improve more benchmarks. #350

Closed duesee closed 1 year ago

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4005617814


Totals Coverage Status
Change from base Build 3996338444: 0.0%
Covered Lines: 30549
Relevant Lines: 56950

💛 - Coveralls
duesee commented 1 year ago

Where do the large changes in performance come from compared to main?

I increased HKDF's okm size for sanity testing. 128 was motivated by HKDF's usage in protocols such as TLS and I feel that it was a good value already. So I reverted this change, which we should hopefully see in the next CI run :-)

The comparison script needs to be updated to print nice output again.

Will do :+1:

With the number of benchmarks we have here now we should probably output a json, or whatever the framework offers, to make it easier to digest with tools.

As discussed off-GitHub, let's do that in a follow-up.