cryspen / hacl-packages

The Cryspen HACL Distribution
https://cryspen.com/hacl-packages
Other
13 stars 18 forks source link

Rust cleanup 3/n #351

Closed franziskuskiefer closed 1 year ago

franziskuskiefer commented 1 year ago

An update to the Rust crate. This mainly adds the hazmat feature, which exposes pure HACL APIs. This is useful when the crate is used in another crypto library that is doing its own hardware feature detection and API on top.

Other changes

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4024516798


Files with Coverage Reduction New Missed Lines %
src/EverCrypt_AutoConfig2.c 13 84.57%
<!-- Total: 13 -->
Totals Coverage Status
Change from base Build 4007061984: -0.02%
Covered Lines: 30536
Relevant Lines: 56950

💛 - Coveralls
duesee commented 1 year ago

No. There are only GNU conventions from the 80s for this. README is ugly and there's no reason not to use something more readable.

Not making people ask (and think about) if you intentionally diverge from a convention seems to be a good reason. Anyway, feel free to ignore. But things like this make it a bit difficult to know when to point out inconsistencies (and when not).

duesee commented 1 year ago

Thanks for making the changes. Do you want to resolve the remaining conversations?