Feat/cmake wasm - Githubissues

cryspen / hacl-packages

The Cryspen HACL Distribution

https://cryspen.com/hacl-packages

Other

13 stars 18 forks source link

Feat/cmake wasm #394

Closed AddressXception closed 1 year ago

AddressXception commented 1 year ago

Add emscripten as a platform target to lowstar endinaness and add x86 as a processor target to x86 builds. Making these changes lets us compile to wasm from source inside our cmake build without having to use the prepackaged wasm files shipped with hacl*. Also, in our use case, this is useful to have more fine grained control over the library for things like compiling with or without optimizations, etc.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4729455722

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.441%

Totals
Change from base Build 4728897283:	0.0%
Covered Lines:	30398
Relevant Lines:	56881

💛 - Coveralls

AddressXception commented 1 year ago

Thanks! I'm not approving yet because we should fix this upstream in karamel. I filed the PR there and will propagate it here. Otherwise this looks good to me.

Do you have an easy way of building emscripten on CI? Then we'd happily run it as part of the CI here.

I'm working on a sane CI integration right now downstream. i'll share here when i have it worked out.