cryspen / hacl-packages

The Cryspen HACL Distribution
https://cryspen.com/hacl-packages
Other
13 stars 18 forks source link

blake2 streaming benchmarks chunking fix #401

Closed karthikbhargavan closed 1 year ago

karthikbhargavan commented 1 year ago

In the Blake2 benchmarks, the streaming functions were ignoring chunk_len (=135) and instead using a chunk size of 7 for HACL/EverCrypt while using the right chunk size for OpenSSL, resulting in incomparable numbers. This PR fixes this issue by using chunk_len everywhere.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4729734163


Files with Coverage Reduction New Missed Lines %
src/EverCrypt_Curve25519.c 11 67.65%
src/EverCrypt_AutoConfig2.c 17 82.1%
src/Hacl_Curve25519_64.c 293 0%
<!-- Total: 321 -->
Totals Coverage Status
Change from base Build 4728897283: -0.6%
Covered Lines: 30080
Relevant Lines: 56881

💛 - Coveralls