cryspen / hacl-packages

The Cryspen HACL Distribution
https://cryspen.com/hacl-packages
Other
13 stars 18 forks source link

External libs for benchmarks #402

Closed karthikbhargavan closed 1 year ago

karthikbhargavan commented 1 year ago

This PR adds several external libraries for benchmarking. In particular, it adds the secp256r1 code generated from ECCKiila, the BLAKE2 reference code, and hash algorithms from Digestif. All this code is kept under the third-party directory.

For now, we only use the portable C code from these libraries. In the future we will also want to use the Neon and AVX2 implementations. We will also add more curves to ECCKiila.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4882882067


Totals Coverage Status
Change from base Build 4859329698: 0.0%
Covered Lines: 30398
Relevant Lines: 56881

💛 - Coveralls
franziskuskiefer commented 1 year ago

Oh, and CI fails. Looks like there's an include missing.

karthikbhargavan commented 1 year ago

Yes, the Neon/AVX2 integration for Blake2 needs a little more work and testing. Putting just the reference code for SHA-2, SHA-3, Blake2, and P-256 in this PR.