Integrate Vectorized SHA3

cryspen / hacl-packages

The Cryspen HACL Distribution

https://cryspen.com/hacl-packages

Other

13 stars 18 forks source link

Integrate Vectorized SHA3 #433

Closed mamonet closed 6 months ago

mamonet commented 7 months ago

This patch imports Hacl_SHA3_Scalar and Hacl_SHA3_Vec256 modules from hacl-star sha3-mb branch and adds sha3-mb.cc test file to test SHA-3 modes for single-lane and 4-lanes.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7084464025

9842 of 12270 (80.21%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+5.0%) to 59.089%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/Hacl_SHA3_Scalar.c	1986	2304	86.2%
src/Hacl_SHA3_Vec256.c	7856	9966	78.83%
<!--	Total:	9842	12270	80.21%	-->

Totals
Change from base Build 7058563693:	5.0%
Covered Lines:	37671
Relevant Lines:	63753

💛 - Coveralls

franziskuskiefer commented 7 months ago

I fixed the examples on main, please cherry pick that commit or do another PR to merge main into dev first to fix that here.

mamonet commented 6 months ago

Does this ever test the vec256 version with 4 different inputs? If not, would be worth adding such a test , or trying with 4 different kats, 4 at a time.

I used 4 different inputs for one shake128 vec256 test.