CI: fix documentation - Githubissues

cryspen / hacl-packages

The Cryspen HACL Distribution

https://cryspen.com/hacl-packages

Other

13 stars 18 forks source link

CI: fix documentation #435

Closed pnmadelaine closed 6 months ago

pnmadelaine commented 7 months ago

This PR tries to fix the GitHub action deploying the documentation. It currently fails on main, but I am unable to reproduce the error locally. This PR also enables building the documentation (but not deploying it) on pull requests, to avoid bad surprises when merging in the future.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7092986748

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.055%

Totals
Change from base Build 7060381243:	0.0%
Covered Lines:	27829
Relevant Lines:	51483

💛 - Coveralls

pnmadelaine commented 6 months ago

It seems that the problem comes from bindgen being broken when using clang 14 and newer. I initially failed to reproduce the error locally because I was still running clang 11. It seems that the rust workflow was already disabled on ubuntu because of this: https://github.com/cryspen/hacl-packages/blob/eb9f9c6d7a2677b3348dbb7e2762a7f9cdce182d/.github/workflows/rust.yml#L43 Since it works on macOS, I suggest we use this for now.