Closed mamonet closed 10 months ago
Totals | |
---|---|
Change from base Build 7420995517: | -1.6% |
Covered Lines: | 37607 |
Relevant Lines: | 65387 |
@mamonet looks like this is broken https://github.com/cryspen/hacl-packages/actions/runs/7211885467/job/19648338337?pr=443#step:8:233
/home/runner/work/hacl-packages/hacl-packages/pr/include/Hacl_Hash_SHA3_Simd256.h:145:3: error: unknown type name 'Lib_IntVector_Intrinsics_vec256'
Lib_IntVector_Intrinsics_vec256 *state,
@mamonet looks like this is broken https://github.com/cryspen/hacl-packages/actions/runs/7211885467/job/19648338337?pr=443#step:8:233
/home/runner/work/hacl-packages/hacl-packages/pr/include/Hacl_Hash_SHA3_Simd256.h:145:3: error: unknown type name 'Lib_IntVector_Intrinsics_vec256' Lib_IntVector_Intrinsics_vec256 *state,
I am aware of this issue, I don't seem to have hac-star generates #include "libintvector.h"
in a header file. I wonder if @karthikbhargavan has a clue about this. Maybe we use uint64 *
instead of Lib_IntVector_Intrinsics_vec256 *
!
What's the state here @mamonet ? Shall we wait for hacl-star/hacl-star#897 before continuing here, or do you want to get this in before? Also not that I merged #442 such that those call sites will need to get updated before we can merge this.
I don't know how to add documents to headers from F* code, I will discuss this with @karthikbhargavan tomorrow and see what I can do.
This parch updates imported SHA3-mb files to latest versions and it changes order of Scalar/Simd256 function parameters of SHA3 modes to meet the convention of original functions.