search

cryspen / hacl-packages

The Cryspen HACL Distribution
https://cryspen.com/hacl-packages
Other
13 stars 18 forks source link

Use crate `cmake` for compiling `hacl_c`. #445

Open thb-sb opened 5 months ago

thb-sb commented 5 months ago

Instead of using process::Command for compiling the CMake project, we can use the cmake crate.

When used, the cmake crate takes care of setting the right profile depending on the opt-level set by Cargo.

Also, the cmake crate allows developers to specify a custom path to the CMake binary by setting the env variable CMAKE (see the README.md).

cla-bot[bot] commented 5 months ago

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

thb-sb commented 5 months ago

mentioning @cryspen/core

franziskuskiefer commented 4 months ago

Sorry for the delay, we will look at this soon.

cla-bot[bot] commented 3 months ago

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

thb-sb commented 3 months ago

up!