Closed s-zanella closed 6 months ago
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.
Thanks! Getting this unified would be great. But running this fails for me right now because it's trying to find the
default_config.h
hacl-packages\tools\configure.py", line 154, in __init__ shutil.copyfile( File "C:\Python312\Lib\shutil.py", line 260, in copyfile with open(src, 'rb') as fsrc: ^^^^^^^^^^^^^^^ FileNotFoundError: [Errno 2] No such file or directory: 'config\\default_config.h'
Thanks! I hadn't tested the configuration script. I restored config/default_config.h
.
Thanks, this looks good. We have to figure out the CI failures, then we can get this in.
Oh, no idea why I closed this. That wasn't intentional. But looks like the branch is gone?
Oh, no idea why I closed this. That wasn't intentional. But looks like the branch is gone?
No worries. This was opened against protz_all_kyber_variants
which got deleted after another merge. I reopened it against dev
as #469
winget
.config.h
files instead of manually copying default configs for MSVC and Clang.