Fix MSVC+CPP issue with including eurydice_glue.h w/ C++17

cryspen / hacl-packages

The Cryspen HACL Distribution

https://cryspen.com/hacl-packages

Other

13 stars 18 forks source link

Fix MSVC+CPP issue with including eurydice_glue.h w/ C++17 #466

Closed samuel-lee-msft closed 1 week ago

samuel-lee-msft commented 1 month ago

Without this MSVC generates error C7555 when eurydice_glue.h is included in any C++ source (https://godbolt.org/z/EqcvcG3Yj)

cla-bot[bot] commented 1 month ago

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9565090194

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.064%

Totals
Change from base Build 9565074420:	0.0%
Covered Lines:	38622
Relevant Lines:	65390

💛 - Coveralls

samuel-lee-msft commented 1 month ago

I am happy to agree to the CLA and be added to the list of contributors for this PR

samuel-lee-msft commented 1 month ago

Let me know if there is anything blocking completion of this PR

franziskuskiefer commented 1 week ago

Sorry for the delay, merging this now.