search

cryspen / hacl-packages

The Cryspen HACL Distribution
https://cryspen.com/hacl-packages
Other
15 stars 18 forks source link

Fix implicit declaration of 'explicit_memset' for NetBSD in Lib_Memzero0.c #475

Closed furkanonder closed 1 month ago

furkanonder commented 1 month ago

I am currently working on building CPython on NetBSD and encountered an error with HACL. After investigating, I found that the issue arises from here. I have implemented a fix in the code. I thought it would be useful to send a pull request to the main repository to fix this issue.

cla-bot[bot] commented 1 month ago

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

furkanonder commented 1 month ago

@cryspen/core

franziskuskiefer commented 1 month ago

Thanks! Unfortunately there's another level of indirection. This fix should to here. Would you mind doing the PR on there?

franziskuskiefer commented 1 month ago

Looks like you fixed it upstream. Thanks! We'll update the code here shortly.