crystal-ameba / ameba

A static code analysis tool for Crystal

https://crystal-ameba.github.io

MIT License

515 stars 35 forks source link

Raise error when passed invalid file paths #394

Closed stufro closed 1 year ago

stufro commented 1 year ago

388

See comment on #388 for my thought process.

I had to change spec/ameba/cli/cmd_spec.cr to use real files to prevent the error being thrown there.
- This also involved changing line 8 of that spec to use a config file which disables some rules defined in spec/spec_helper.cr which always adds errors.

Sija commented 8 months ago

This broke ameba's github action :( Also, I believe it's incorrect to raise for invalid paths in Globs or Excluded - these can be potentially empty or missing and neither of these should be a reason to raise an error and halt the execution of the whole program.

stufro commented 8 months ago

Ah sorry about this @Sija. I'm happy to have a look at resolving this but won't likely have time for several weeks so it might be best to revert this PR for now.

Sija commented 8 months ago

@stufro No worries, let's revert this PR for now and take care of it l8r.