Closed straight-shoota closed 7 months ago
@straight-shoota This PR broke my local setup (macOS 12.7) :(
make
-> make: Nothing to be done for 'all'.
make build
-> make: Nothing to be done for 'build'.
Are you sure any of the source files changed since you last ran make
?
This patch added the entire source tree as a dependency of the build
recipe. So it won't rebuild if the source hasn't changed.
You can force a rebuild with make -B
.
You could also try make -d
to get some debug information on which dependencies were considered and what lead to not building.
Are you sure any of the source files changed since you last ran
make
? This patch added the entire source tree as a dependency of thebuild
recipe. So it won't rebuild if the source hasn't changed. You can force a rebuild withmake -B
.
Yeah, I'm sure. Also, make -B
didn't change a thing, it's the same story: make: Nothing to be done for 'all'.
make -d
Hm, looks like make doesn't recognize the prerequisites (SRC_SOURCES
) at all.
Maybe try this diff to see if there are any errors with the find command? Would be very strange though...
@@ -28,7 +28,7 @@ INSTALL_BIN ?= /usr/bin/install
SHARD_BIN ?= ../../bin
CRFLAGS ?= -Dpreview_mt
-SRC_SOURCES ::= $(shell find src -name '*.cr' 2>/dev/null)
+SRC_SOURCES ::= $(shell find src -name '*.cr')
DOC_SOURCE ::= src/**
Looks like your make version is really ancient. You might want to update to a more modern version. (Dunno if that could be of any relevance here)
Nope, doesn't work. Also what's interesting when I run this command from my terminal I get:
λ Shabdiz → shell find src -name '*.cr'
zsh: command not found: shell
$(shell xxx)
is a make function: https://www.gnu.org/software/make/manual/html_node/Shell-Function.html
It means run xxx
in the shell.
So could you try if find src -name '*.cr'
works for you? I don't know how that could fail 🤷 It should print the paths of all source files.
Yeah, that works just fine.
Solution was to install make
from homebrew (v4.4.1).
I figured the
Makefile
could use some love after it failed me in some capacities.install
recipe does not rebuild binaryhelp
target and documentationBased on template https://gist.github.com/straight-shoota/275685fcb8187062208c0871318c4a23