Add rule enforcing explicit return

[nobodywasishere]

While implicit return is nice, sometimes it can cause unintended effects / footguns. Would it be possible to add a (disabled by default) rule that's the exact opposite of Style/RedundantReturn, encouraging the use of explicit returns?

[straight-shoota]

Could you show a case where implicit return would be a footgun?

[z64]

@straight-shoota We had an unnoticed buggy method that was effectively

def something : Bool
  if cond
    # .. extra evaluation ..
    true
  end
  false
end

which was unlikely to ever be written in the first place if implicit returns didn't exist. You would never just write naked true that you intended to return.

The subjective benefit of implicit return's brevity is outweighed by

• All the other languages we work with in our stack (Go, JS, Python, C/C++) all require return. From this POV Crystal appears inconsistent and confusing to onboarders.
• Being able to grep for the return expression instead of having to eyeball it
• Not losing to the habits of using implicit returns causing bugs like above

So we are more than fine with enforcing it.

[straight-shoota]

I suppose this requires semantic analysis for being any good. Without a semantic pass you dont know which code paths are NoReturn. So it would require return where no value is returned at all.

So at this point ameba cannot implement this.

[straight-shoota]

@z64 Regarding the consistency argument: There are far more significant differences between the semantics of different programming languages than implicit returns - which is actually a very obvious one.

Anyway I believe for that example it might be helpful to recognize a "naked true" and other unused values. This is of course limited because method calls might only exist for side effexts and legitimately not be interested in the return type. But simple cases like this one would be something a linter could recongnize and complain about.

[Sija]

Without semantic analysis that's going to be pretty useless, as mentioned already by @straight-shoota.