crystal-ameba / github-action

A GitHub Action that lints Crystal code with Ameba
MIT License
29 stars 6 forks source link

Links to annotations point to wrong address #6

Closed Sija closed 1 year ago

Sija commented 4 years ago

image

Clicking on Check warning on line ... link leads to /commit/<commit-sha>#annotation_<id>, where there's neither the request file nor annotation nowhere to be found.

veelenga commented 4 years ago

This action inspects a hole project (not the change) and adds an annotation to a specific commit. Since your linting issue is not a part of that change (is was introduced in some commit before), GitHub doesn't show the annotation as part of a linked commit.

I will have to think about some solutions, but it looks like there is no good way to handle it.