search

crystal-bit / godot-game-template

Generic template for Godot games
MIT License
598 stars 47 forks source link

Don't retain artifacts longer than a day #78

Closed idbrii closed 1 year ago

idbrii commented 1 year ago

Add retention-days: 1 to all builds. Switched to upload-artifact@v3 (not sure it's necessary).

We upload artifacts so we can publish them to itch and gh-pages, but we don't really need the builds after that. You can quickly run into the 0.75 GB limit from Github free for artifacts that are no longer relevant.

While it can also be useful to download artifacts from the Actions page, it seems better to err on the side of making it easy to increase lifetime instead of no clear lifetime.

Draft because I've already hit my Actions storage budget and even deleting all my workflow runs didn't decrease my used Storage for Actions and Packages so I can't actually test this until that quota refills. But I'd still like feedback whether this is a desirable change.

Note: It's also possible to change a repo's artifact retention period, but that would affect Dispatch Export builds which presumably you'd want to keep around longer (I think that's their purpose).

davcri commented 1 year ago

Hi @idbrii thanks for the PR. This is a very appreciated feature. I think it may help most of the users.

I don't have much experience with Github CI, but the changes you suggested seems fine.
I'm okay with merging the changes and test them on my main branch!

idbrii commented 1 year ago

Okay, sounds good. Thanks for the great template!