search

crystal-bit / godot-game-template

Generic template for Godot games
MIT License
598 stars 47 forks source link

Made Github Pages run properly by adding coi-serviceworker #89

Closed SecurityRisk closed 6 months ago

SecurityRisk commented 6 months ago

coi-serviceworker allows the CORS errors to go away when running on a static github pages webpage

SecurityRisk commented 6 months ago

88 resolution

davcri commented 6 months ago

Hi @SecurityRisk thanks for the PR. I never heard about coi-serviceworker, let's see if this works. I'm going to merge the PR and see if the new build runs fine.

~~I guess there will be still the SharedArrayBuffer error, I don't know if Godot 4 can work without it (like Godot 3.x).
Probably I'll have to host the webapp elsewhere to make it work.~~ EDIT: it fixed also the SharedArrayBuffer error, amazing! Thanks again for the PR 🎉 However I think this configuration should be offered as opt-in and not the default.