search

crystal-bit / godot-game-template

Generic template for Godot games
MIT License
651 stars 47 forks source link

Add godot-coi-serviceworker #93

Closed davcri closed 6 months ago

davcri commented 10 months ago

Fixes #90

Using https://github.com/nisovin/godot-coi-serviceworker is pretty nice as it exposes this toggle option in the export preset menu:

image

As long as I like the addon and its ease of use, I wonder how many people in percentage are going to take advantage of this feature.

I think <25% of Godot users care about HTML5 export. A fraction of that 25% cares about COI since many deploy to Itch.io or other platforms that allow configuring a suitable setup for Godot 4 HTML exports.

I'm not sure if it's better to:

  1. leave this addon disabled by default
  2. remove this addon and just put some documentation in the readme

Feedback is welcome!

SecurityRisk commented 10 months ago

This addon seems really neat. I like having this be full-service in that, if anyone picked it up and was expecting it to work on a static site they can without making changes. But at the same time, I know this is unnecessary for those who know how they're exporting.

I think adding it to the README is a great idea. As it gives notice to how to fix the potential issue for those who want it without making it mandatory. I'd rather it not bloat the template since it's much more of an option than a necessity

davcri commented 6 months ago

Closing as this hopefully is going to be handled upstream https://godotengine.org/article/progress-report-web-export-in-4-3/