search

crystal-bys / pe

0 stars 0 forks source link

No error handling on spammed names #6

Open crystal-bys opened 1 week ago

crystal-bys commented 1 week ago

Problem: There is no character limit as to how long the name should be, so even when the name (input) is ridiculously long, the product accepts what is inputted.

Suggestion: Moving forward, the development team can limit name characters to (for example) a maximum number of 100 characters to prevent spamming of invalid names.

Input and Output example: image.png

nus-pe-bot commented 1 week ago

Team's Response

Hi, thank you for the bug report. We acknowledge that there is no character limit in the add Patient Command. However, in a hospital setting, while it is rare, there may be cases where names exceed 100 characters. Despite this, the application currently handles such inputs without any functional issues. Specifically, the UI continues to display the message as follows:

This behaviour is shown in the annotated screenshot below:

image.png

Severity Classification: Based on the bug triaging guidelines under admin info:

image.png

This issue should be assigned a severity level of VeryLow instead of Medium, as:

Resolution and Future Considerations: Moving forward, we could consider implementing a warning to inform users if they input a name exceeding 100 characters. However, the patient would still be added to the list to ensure functionality is not hindered. This enhancement would primarily serve as a quality-of-life improvement.

That said, implementing such a character limit is currently out of scope for this version. We have therefore categorised this issue as NotInScope while acknowledging its potential for future iterations.

Thank you again for your report and suggestion, which will help us further improve the application.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]