search

crystal-cat / exif_rename

A tool for batch renaming image files based on their (creation) date
GNU General Public License v3.0
0 stars 0 forks source link

Separate simulated and real renaming into different classes #25

Closed crystal-cat closed 4 years ago

crystal-cat commented 4 years ago

Separate the logic of renaming for real and simulating into different subclasses of Renamer to reduce ifs and complexity of functions like find_unique_filename()

airtower-luna commented 4 years ago

With the move command logs being moved to where they're executed we'll have to update (or remove) the MoveTest.test_renamer_mv_cmd_simulate(), because it won't receive any such logs during a simulate run. Might be best to integrate the log check into a real move test.

airtower-luna commented 4 years ago

@crystal-cat Here are my proposals, let me know what you think! :cat:

Oh, and if you want to squash things together before merging, we could try the Co-authored-by: thing!