search

crystal-community / icr

Interactive console for Crystal programming language
MIT License
505 stars 40 forks source link

Remove 'tempfile' #102

Closed blazerw closed 5 years ago

blazerw commented 5 years ago

'tempfile' is no longer 'require'd.

It appears that 'tempfile' is either required by default or part of Crystal 0.27 core. Removing the 'require' results in a successful compile and a working icr.

veelenga commented 5 years ago

Does that mean ICR will become incompatible with Crystal 0.26?

jwoertink commented 5 years ago

Maybe? My ICR works currently with 0.26. I haven't tried 0.27 yet. I was waiting on the homebrew PR to be merged. If that's the case, maybe we can add a macro to require it conditionally based on the crystal version? Then deprecate it for when 0.28 comes out?

veelenga commented 5 years ago

Just tested it. This is the only incompatibility with 0.27.0 

in src/icr.cr:2: while requiring "tempfile": can't find file 'tempfile'

i will prepare a new release.