search

crystal-community / icr

Interactive console for Crystal programming language
MIT License
505 stars 40 forks source link

Command type detection bug #61

Closed ktaragorn closed 7 years ago

ktaragorn commented 7 years ago

Test case - Reference.new == Reference.new Even though this is an equality check, this is being caught as a constant_assignment command and so is wrongly treated. You do not get the output of the command.

ktaragorn commented 7 years ago

Is the .+ in /^[A-Z]+([a-z_0-9].+)?\s*\={1}[^=~]/ intentional or a bug? Seems like should be +

ktaragorn commented 7 years ago

also i think \={1} should be just =

ktaragorn commented 7 years ago

Ill try to create a PR into this tomorrow

veelenga commented 7 years ago

Yup, seems to be introduced in https://github.com/crystal-community/icr/pull/59.