search

crystal-community / jwt

JWT implementation in Crystal
MIT License
206 stars 24 forks source link

Crystal 0.20 fix #2

Closed alanwillms closed 7 years ago

alanwillms commented 8 years ago

Fix an issue where Base64.urlsafe_encode adds extra = characters to the end of its output in Crystal 0.20.

andrewhamon commented 7 years ago

@greyblake I've verified that a) this is indeed an issue, and b) that the fix works.

It looks like the Ruby jwt library takes a similar approach: https://github.com/jwt/ruby-jwt/blob/master/lib/jwt.rb#L175-L177

andrewhamon commented 7 years ago

@greyblake don't forget to make a new release :)

greyblake commented 7 years ago

Ahh)I've merged with my phone, and i am without laptop for the weekend. I'll do it on Monday) Thanks) Please don't hesitate to ping me, if I forget)

On Dec 10, 2016 22:57, "Andrew Hamon" notifications@github.com wrote:

@greyblake https://github.com/greyblake don't forget to make a new release :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/greyblake/crystal-jwt/pull/2#issuecomment-266242875, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG7aO-AzdriefJaA5twyfRMaP5UJOgwks5rGyBUgaJpZM4K9OBm .

andrewhamon commented 7 years ago

No worries, will do! Thanks!

andrewhamon commented 7 years ago

Here's another friendly reminder 😉

andrewhamon commented 7 years ago

Also, you should totally set up a cron job with travis, which is a feature I just discovered. That should uncover breaking changes in Crystal before users are affected.

greyblake commented 7 years ago

@andrewhamon Thanks! Please check v0.2.2

andrewhamon commented 7 years ago

@greyblake It looks like the version field in shard.yml hasn't been bumped

greyblake commented 7 years ago

Oops. My bad, looks like it was never bumped. Thanks for cathing that)

greyblake commented 7 years ago

I've updated it

andrewhamon commented 7 years ago

Awesome! Annnnnnd now we just need the Github release/v0.2.2 tag

greyblake commented 7 years ago

It is there) just pushed

On Dec 13, 2016 10:46, "Andrew Hamon" notifications@github.com wrote:

Awesome! Annnnnnd now we just need the Github release/v0.2.2 tag

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/greyblake/crystal-jwt/pull/2#issuecomment-266693188, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG7aO6qca9pFdeIgDbUOLeigQvpQrQTks5rHmmFgaJpZM4K9OBm .