search

crystal-community / jwt

JWT implementation in Crystal
MIT License
206 stars 24 forks source link

Fix for Crystal 0.35.0 #33

Closed jamescook closed 4 years ago

jamescook commented 4 years ago

I ran into the below error until I updated the dependencies.

06:31 $ crystal spec
Showing last frame. Use --error-trace for full trace.

In /usr/local/Cellar/crystal/0.35.0/src/io.cr:845:34

 845 | def write_byte(byte : UInt8) : Int64
                                      ^
Error: method must return Int64 but it is returning (Int64 | Nil)

https://github.com/stakach/openssl_ext/compare/v1.2.0...stakach:v1.2.1 https://github.com/spider-gazelle/bindata/compare/v1.5.3...v1.5.4

More background: https://github.com/crystal-lang/crystal/issues/9454

xaviablaza commented 4 years ago

Hello, could we please merge this into the upstream?

jamescook commented 4 years ago

Crystal 0.35.1 reverted the change to IO#write that is causing errors. I don't think this PR is needed anymore.

xaviablaza commented 4 years ago

Agree, this is no longer needed -- the dependencies have also been updated to reflect the reverted changes.