crystal-data / num.cr

Scientific computing in pure Crystal
MIT License
151 stars 12 forks source link

[ENH] Rewrote core #13

Closed christopherzimmerman closed 4 years ago

jkthorne commented 4 years ago

what was this rewrite for?

christopherzimmerman commented 4 years ago

@wontruefree if you look at what was previously the arrayops folder, I had several instances of macros that did basically the entire thing, and also lots of code to broadcast tensors against each other, broadcast scalars, upcast scalars, so I finally got around to implementing it in a central location.

Also you'll notice lots of the benchmarks are much faster, a factor of almost 5x for reductions and accumulations in some cases.

jkthorne commented 4 years ago

awesome I was just curious.