search

crystal-lang-tools / sublime-crystal

Crystal syntax highlighting for Sublime Text
Other
86 stars 18 forks source link

Octal literals have no scope applied to them #40

Open faultyserver opened 6 years ago

faultyserver commented 6 years ago
screen shot 2018-04-01 at 3 12 39 pm

Unlike Ruby, which just uses a prefix 0 to denote octal literals, Crystal uses 0o (which I really like). However, this difference is not handled in the current syntax highlighter, meaning octal literals have no scope applied to them, and thus can't be highlighted.

To match other numeric literals, octal literals should get the scope constant.numeric.crystal.

faultyserver commented 6 years ago

Support for octal numbers is already part of the syntax. I'm not sure why this particular case wasn't highlighting before, but I went back to it and it is now. This issue can probably be closed unless someone else has a way of reproducing it?