crystal-lang-tools / vscode-crystal-lang

Yet another VSCode extension for Crystal Programming Language
https://marketplace.visualstudio.com/items?itemName=crystal-lang-tools.crystal-lang
MIT License
276 stars 58 forks source link

Non ascii chars might be lost after formatting #114

Closed bcardiff closed 3 years ago

bcardiff commented 4 years ago

Even if the formatter returns no changes.

One of the examples I have is in https://github.com/crystal-lang/crystal/blob/b977a952e142efe5ee63e65e7820eec2b55a0c07/spec/std/io/io_spec.cr#L622

Extension version 0.4.0

$ crystal --version
Crystal 0.34.0 (2020-04-07)

LLVM: 10.0.0
Default target: x86_64-apple-macosx

How does it looks?

CMIgznz7l7

pyritewolf commented 4 years ago

For more context, this happens when Format on Save is enabled in VSCode's user configs, even if the plugin's features are all disabled

Screen Shot 2020-07-28 at 14 09 44
max-bertinetti commented 3 years ago

On version 0.6.2 is not happen anymore.

I close the issue.

image (Afer Save with Format on Save enabled)