crystal-lang-tools / vscode-crystal-lang

Yet another VSCode extension for Crystal Programming Language
https://marketplace.visualstudio.com/items?itemName=crystal-lang-tools.crystal-lang
MIT License
276 stars 58 forks source link

Explicitly set UTF-8 encoding when formatting #121

Closed lmatayoshi closed 4 years ago

lmatayoshi commented 4 years ago

For https://github.com/crystal-lang-tools/vscode-crystal-lang/issues/114

STDOUT streamed data is being returned as a Buffer object because encoding property was never set (it's null by default: https://nodejs.org/api/stream.html#stream_readable_setencoding_encoding). Explicitly setting stdout's stream encoding to UTF-8 helps parse formatter's output correctly.