Upgrade depencencies - Githubissues

crystal-lang-tools / vscode-crystal-lang

Yet another VSCode extension for Crystal Programming Language

https://marketplace.visualstudio.com/items?itemName=crystal-lang-tools.crystal-lang

MIT License

276 stars 58 forks source link

Upgrade depencencies #126

Closed elbywan closed 3 years ago

elbywan commented 3 years ago

Description

This PR updates all the dependencies, most notably:

removes the deprecated vscode package and replaces it with the up-to-date @types/vscode and vscode-test packages.
updates the language server client to support the new features

Why?

I am currently writing Crystalline, a Crystal LSP server and I need a client that has progress support. Unfortunately with the current outdated dependencies this is not the case as of today, hence this PR.

max-bertinetti commented 3 years ago

Hi @elbywan, thank you for your PR.

Can I just ask why Crystalline? What's the differences with Scry? Can we speak about it?

elbywan commented 3 years ago

Hi @maxbertinetti,

Thanks for merging the PR!

Can I just ask why Crystalline? What's the differences with Scry? Can we speak about it?

Good timing I just wrote a forum post about it 😄.

Well Scry has never been working for me, and I did not see anyone working on it to improve the situation. So I decided to rewrite the whole thing from scratch (to be honest I maybe reused 50 lines of code from Scry).

max-bertinetti commented 3 years ago

Do you like Crystalline included in this organisation (I need to speak with some people for that to happen, but just to be sure is something that you can like)?

Many ppl ask about Scry improvement but I don't know anyone directly involved in it actually. I think that can be interesting to collaborate so that VS Code / Crystalline / Ameba can become a defacto standard for developing Crystal for v.1.0.0 release!