search

crystal-lang-tools / vscode-crystal-lang

Yet another VSCode extension for Crystal Programming Language
https://marketplace.visualstudio.com/items?itemName=crystal-lang-tools.crystal-lang
MIT License
276 stars 58 forks source link

Syntaxes: fix regex escapes #146

Closed joseafga closed 2 years ago

joseafga commented 3 years ago

Regex metacharacters escapes (like \., \*, \[, ...) not work, e.g. \/ breaks syntax highlight. Changed it to match any single char escape. Based on vscode-ruby.

Before: Screenshot_20210719_112522

After: Screenshot_20210719_112720

joseafga commented 3 years ago

This PR fix issue #147

jwoertink commented 2 years ago

I know this PR has been sitting a bit, but I'm curious if it also fixes this issue I'm having:

Screen Shot 2021-09-29 at 10 13 40 AM
joseafga commented 2 years ago

I know this PR has been sitting a bit, but I'm curious if it also fixes this issue I'm having: Screen Shot 2021-09-29 at 10 13 40 AM

apparently yes Screenshot_20210930_030407

jwoertink commented 2 years ago

Sweet! Maybe we can ping a maintainer to see if someone can get this merged in?

matthewmcgarvey commented 2 years ago

In the meantime, you can clone this repo into ~/.vscode/extensions/crystal-lang-tools.crystal-lang-0.8.2

In the directory:

git fetch origin pull/146/head:fix_regex_escapes
git checkout fix_regex_escapes
matthewmcgarvey commented 2 years ago

@bcardiff Is there a maintainer that could merge and release this PR? Jeremy and I have both verified that it works

bcardiff commented 2 years ago

I can merge it, and I see the github workflow to publish, but I am not sure about the process regarding versioning and changelog.

@mbertinetti is the main maintainers nowadays. If there is no response during this week I should be able to perform the actions somehow.