search

crystal-lang / crystal-mysql

MySQL connector for Crystal
MIT License
107 stars 36 forks source link

Convert auth_data_length to a signed integer #4

Closed zachad closed 8 years ago

zachad commented 8 years ago

Created patch to fix #3

I chose to use .to_i16 because it keeps that line looking like the mysql protocol spec documentation: https://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::Handshake

bcardiff commented 8 years ago

I agree that to_i16 was the best option. Merged at 6db306e so v0.1.2 is available. It is already in master.

Thanks!