search

crystal-lang / crystal-website

crystal-lang.org website
61 stars 77 forks source link

Fixing base url for feed content #791

Closed beta-ziliani closed 5 months ago

netlify[bot] commented 5 months ago

Deploy Preview for crystal-website ready!

Name Link
Latest commit f057d951333c5d5858842003684cb56de1019b52
Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/664b534ea641700008a93d38
Deploy Preview https://deploy-preview-791--crystal-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

straight-shoota commented 5 months ago

What's the reason for this change? I'd expect the base URL to be the path to the post, not the home page, to make path-relative links work.

beta-ziliani commented 5 months ago

but what is /2024/04/09/1.12.0-released/ in this context?

straight-shoota commented 5 months ago

It's a fully qualified URL (note the absolute_url filter): https://crystal-lang.org/2024/04/11/1.12.1-released/ So any relative link inside the content would be properly scoped to this context, not the root of the website.

beta-ziliani commented 5 months ago

OK, maybe it's just that the RSS viewers I checked they all display this wrongly, linking it to their own / 🤷

straight-shoota commented 5 months ago

What did you see in RSS viewers? I still don't understand what's the issue. Maybe we do need to fix something.