search

crystal-lang / crystal-website

crystal-lang.org website
60 stars 75 forks source link

Fix `sponsors_logos_l` to require a logo #795

Closed straight-shoota closed 3 months ago

straight-shoota commented 3 months ago

Ref https://github.com/crystal-lang/crystal-website/pull/792/files#r1622646393

netlify[bot] commented 3 months ago

Deploy Preview for crystal-website ready!

Name Link
Latest commit f43e68a6d1338d3133f7ae9ee78fd77417f911a1
Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/6659f7dbaa93c40008a561e5
Deploy Preview https://deploy-preview-795--crystal-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

beta-ziliani commented 3 months ago

We need a different approach to this. This is a very special case, but this person put that money and asked to have the link on the page, so it's only fair to have it there, even if with an empty picture.

beta-ziliani commented 3 months ago

PS: I asked him to put a pic a week ago, but didn't hear back from him yet.

straight-shoota commented 3 months ago

I suppose we could also add an empty image 🤷

straight-shoota commented 3 months ago

Obsolete due to https://github.com/crystal-lang/crystal-website/pull/797