search

crystal-lang / crystal-website

crystal-lang.org website
60 stars 75 forks source link

Adding empty image for sponsor with no logo #797

Closed beta-ziliani closed 3 months ago

beta-ziliani commented 3 months ago

Replaces #795

netlify[bot] commented 3 months ago

Deploy Preview for crystal-website ready!

Name Link
Latest commit a2fd7ca4af50ffd62395f9ab40a9fb3e15e8051e
Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/665f6f300801350008b2a20c
Deploy Preview https://deploy-preview-797--crystal-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

straight-shoota commented 3 months ago

I believe it would be easier to assign the empty logo in the sponsor data. We should be able to do that by putting a metching entry with logo in _data/others.json. This would avoid introducing more complexity into the template. This can be handled on the data side, so it's best to do it there.

Also this particular SVG is certainly not approvable. I would consider keeping it completely blank maybe?

beta-ziliani commented 3 months ago

Done that, although the merge system is not great for this. We should implement a better strategy in the future; one that doesn't require so many fields when just needing to override one.

straight-shoota commented 3 months ago

@beta-ziliani I understand partial merge should work with overrides property... I believe it did in the past. But might need to look into. We can merge this of course.