crystal-lang / crystal

The Crystal Programming Language
https://crystal-lang.org
Apache License 2.0
19.37k stars 1.62k forks source link

Use `boehmgc` package from nixpkgs in `shell.nix` #14591

Closed straight-shoota closed 4 months ago

straight-shoota commented 4 months ago

This is largely a simplification. I don't think we need to build our own derivation of the GC when there's already a generic one in nixpkgs. With overrides we get almost the same configuration as our custom build. The custom build was previously necessary because we required unreleased patches. That's gone now and we should be fine with any recent upstream version.

Most significant changes as far as I can see are some compile flags are gone:

mamantoha commented 4 months ago

Hi @straight-shoota . Could this change be related to the issue with crystal-lang/install-crystal GitHub Action that causes an error with Crystal Nightly? Check this link for an example.

image

straight-shoota commented 4 months ago

No, that's completely unrelated. The installer issue was caused by https://github.com/crystal-lang/distribution-scripts/pull/300 and is already fixed (#14594). Unfortunately, today's nightly build is broken for yet another reason, but should be fixed shortly by #14595.