crystal-lang / crystal

The Crystal Programming Language
https://crystal-lang.org
Apache License 2.0
19.22k stars 1.61k forks source link

Refactor win32 `System::FileDescriptor#unbuffered_{read,write}` #14607

Closed straight-shoota closed 1 month ago

straight-shoota commented 1 month ago

Extracts blocking read and write implementations into separate methods, #read_blocking and #write_blocking to harmonize the level of abstraction in #unbuffered_read/#unbuffered_write.

I'm not touching the buffered branch because it's going to be a single call after the event loop refactor.