search

crystal-lang / crystal

The Crystal Programming Language
https://crystal-lang.org
Apache License 2.0
19.21k stars 1.61k forks source link

Enable ameba linter #14631

Open Sija opened 1 month ago

Sija commented 1 month ago

Resolves #14608

Sija commented 1 month ago

I've managed to get it running after a few tries - GHA don't allow GITHUB_TOKEN secret usage unless the proper permissions are given (see this SO question for example), so for the time being I've circumvented the problem by using a locally installed version, so we can see the actual output.

Finished in 51.78 seconds
2041 inspected, 373 failures
Sija commented 1 month ago

I've cooked a config file which disables the biggest offenders and (most likely) unwanted rules. Next steps I can think of are as follows:

  1. Scrutinize current .ameba.yml config file choices
  2. Triage existing issues
  3. Discern between the issues to correct and the ones to ignore
  4. Act accordingly
straight-shoota commented 1 month ago

What do you need GITHUB_TOKEN secret for?

Sija commented 1 month ago

@straight-shoota Ameba's github action needs it.

ysbaddaden commented 1 month ago

@straight-shoota It needs the token to report Ameba issues as comments on the PR.