search

crystal-lang / crystal

The Crystal Programming Language
https://crystal-lang.org
Apache License 2.0
19.36k stars 1.62k forks source link

Fix abstract def parameter name in `LibEvent::EventLoop#send_to` #14658

Closed straight-shoota closed 4 months ago

straight-shoota commented 4 months ago

Fixup for #14643

ysbaddaden commented 4 months ago

I believe the other implementations are also affected:

src/crystal/system/wasi/event_loop.cr
55:  def send_to(socket : ::Socket, slice : Bytes, addr : ::Socket::Address) : Int32

src/crystal/system/win32/event_loop_iocp.cr
182:  def send_to(socket : ::Socket, bytes : Bytes, addr : ::Socket::Address) : Int32
ysbaddaden commented 4 months ago

And now it complains about the bytes param on Windows :weary: