search

crystal-lang / crystal

The Crystal Programming Language
https://crystal-lang.org
Apache License 2.0
19.21k stars 1.61k forks source link

Rename `Crystal::NilableType` to `NilableReferenceType` #14700

Open HertzDevil opened 3 weeks ago

HertzDevil commented 3 weeks ago

The name NilableType suggests that other types like NilableReferenceUnionType and NilableProcType inherit from it, but this is not the case.

straight-shoota commented 3 weeks ago

The name is still not ideal because NilableReferenceUnionType and NilableReferenceType are pretty similar. Both inherit from UnionType which doesn't help making sense of the only difference in the names.

Perhaps we can find an even better naming solution?