Enable specs for `close_on_exec` on Windows

crystal-lang / crystal

The Crystal Programming Language

https://crystal-lang.org

Apache License 2.0

19.2k stars 1.61k forks source link

Enable specs for `close_on_exec` on Windows #14716

Open straight-shoota opened 2 weeks ago

straight-shoota commented 2 weeks ago

These specs be enabled on Windows as well to ensure the expected behaviour (even though there's no mechanism for changing the value).

ysbaddaden commented 2 weeks ago

Looks good, but I would wait a bit for #14717 to decide if we change the default (IMO: we should) and do it in one go.

straight-shoota commented 2 weeks ago

I'd actually prefer to merge this first, and then the PR for https://github.com/crystal-lang/crystal/issues/14717 on top. That way the effective change in behaviour will be explicitly documented in the spec changes.

Also there's really no reason to postpone this addition. It's merely enabling specs for current behaviour. And as such is a different concern than changing behaviour.