search

crystal-lang / crystal

The Crystal Programming Language
https://crystal-lang.org
Apache License 2.0
19.2k stars 1.61k forks source link

Regression: Socket#connect with number timeout (deprecated) #14753

Closed ysbaddaden closed 4 days ago

ysbaddaden commented 6 days ago

fixes #14752

straight-shoota commented 5 days ago

This doesn't really work out well without adding type restrictions to the timeout parameter in the non-deprecated overload. We should do this anyway, but it's a step further. I think we should revert to the previous behaviour first with the patch from https://github.com/crystal-lang/crystal/issues/14752#issuecomment-2190030736.