crystal-lang / crystal

The Crystal Programming Language
https://crystal-lang.org
Apache License 2.0
19.2k stars 1.61k forks source link

Codegen: stats and progress issues #14763

Open ysbaddaden opened 4 days ago

ysbaddaden commented 4 days ago

The --stats and --progress params had a couple issues:

Idea for a follow-up: the report fiber of forked codegen could set unit.reused_previous_compilation instead of collecting reused module names, then we wouldn't need to collect the module names into a reused array (we can trust units to be updated) and the #print_codegen_stats method would count & filter has needed.

ysbaddaden commented 3 days ago

@sdogruyol I assume you faced the issue?

sdogruyol commented 3 days ago

@sdogruyol I assume you faced the issue?

Yes, I recently experienced --stats issue on Windows

ysbaddaden commented 8 hours ago

Merged with master to fix conflict with #14762.