search

crystal-lang / crystal_lib

Automatic binding generator for native libraries in Crystal
138 stars 30 forks source link

Fix: wrong ErrorType parsing when a type is referenced before it's defined #65

Open olbat opened 4 years ago

olbat commented 4 years ago

Fixes #64 Fixes #57

olbat commented 4 years ago

CI is failing but it doesn't look related to the change...

olbat commented 4 years ago

It looks like this PR fixes https://github.com/crystal-lang/crystal_lib/issues/57 too.

RX14 commented 4 years ago

Anyone else gonna review this or I'll just merge?

We should work out whether we have the interest among the core team to at least review PRs for this repo.

olbat commented 4 years ago

Hey 👋 Can we consider to merge this fix now it's approved?