search

crystal-lang / distribution-scripts

40 stars 24 forks source link

Remove unused software and patches from omnibus #111

Closed bcardiff closed 3 years ago

bcardiff commented 3 years ago

This PR extracts the cleanups from #104

A maintenance build has been triggered at https://app.circleci.com/pipelines/github/crystal-lang/crystal/6450/workflows/1845fb8d-917e-4326-b462-2b1b8a2ab7e5

Since the compiler does not link to openssl and libevent_openssl is not used I think we are good to drop those. openssl.rb was introduced by https://github.com/crystal-lang/omnibus-crystal/commit/eca9b66f52ca7c9cbbac0a73acffdba6e59763b0#diff-05cbe0a6a9b14d404660e58981b5e95f7ec556e4d6673d9a84fad51efd8dc84e and I don't recall the exact reason of it.

bcardiff commented 3 years ago

I tested a 2nd gen compiler with this branch using maintenance build at https://app.circleci.com/pipelines/github/crystal-lang/crystal/6549/workflows/424cfcf4-2670-4342-af9b-229841f7d390/jobs/63032/artifacts and everything seems fine for darwin.

Note that besides updating distribution-script's sha the ruby version needs to be updated.