crystal-lang / distribution-scripts

40 stars 24 forks source link

Fix ARG in multistage `bundled.Dockerfile` #148

Closed straight-shoota closed 2 years ago

straight-shoota commented 2 years ago

ARG instructions in a Dockerfile need to be repeated for every stage in a multistage build. I have no idea why this worked when I first tested it, but now it doesn't anymore (https://github.com/crystal-lang/distribution-scripts/pull/143#issuecomment-933596413). Apparently, it should've never worked. https://github.com/crystal-lang/distribution-scripts/pull/102#discussion_r722506331

Successful CI run: https://app.circleci.com/pipelines/github/crystal-lang/crystal/6956/workflows/b013a39d-3bcc-4c07-b3c6-b3cc581649ed/jobs/64412