search

crystal-lang / distribution-scripts

40 stars 24 forks source link

Update to libpcre2 #219

Closed straight-shoota closed 1 year ago

straight-shoota commented 1 year ago

This is a part of the effort to migrate the regex engine to PCRE2 (https://github.com/crystal-lang/crystal/issues/12790).

With https://github.com/crystal-lang/crystal/pull/12978, PCRE2 becomes the default engine at which point we should ship libpcre2 in the packages where we distribute the regex library. That's the bundled tarball and the docker images.

beta-ziliani commented 1 year ago

@straight-shoota I'm certain I didn't break anything with my merge commit, but please double check before merging. Thanks mate!

straight-shoota commented 1 year ago

Oh, I'm pretty sure you did. The merge commit picks the COPY --from=libpcre line from master which breaks the docker build.